I'll try to review the remaining patches this afternoon.
On Wed, Sep 17, 2014 at 05:32:40PM +1200, Joe Stringer wrote: > Bump. Any chance of some feedback? > > On 15 September 2014 14:25, Joe Stringer <joestrin...@nicira.com> wrote: > > > Patches #1-4 have been reviewed and Ack'd by Ben, which I have held out > > from > > pushing upstream as they are only useful with the rest of the series. The > > remaining patches are yet to be reviewed. > > > > This series is also made available here to assist review: > > https://github.com/joestringer/openvswitch/tree/submit/ufid_v5 > > > > v5: > > - Rebase > > - Various bugfixes > > - Improve logging > > > > v4: > > - Datapath memory leak fixes > > - Enable UID-based terse dumping and deleting by default > > - Shifted UID generation down to dpif > > - Log flow UIDs in more places > > - Various fixes > > > > RFCv3: > > - Add datapath implementation > > - Minor fixes > > - Rebased > > > > RFCv2: > > - Revised early patches from v1 feedback > > - Add Acks from Ben > > - Rebased > > > > RFCv1: > > http://openvswitch.org/pipermail/dev/2014-August/044383.html > > > > Joe Stringer (12): > > revalidator: Use 'cmap' for storing ukeys. > > revalidator: Protect ukeys with a mutex. > > udpif: Separate udpif_key maps from revalidators. > > upcall: Rename dump_op -> ukey_op. > > upcall: Create ukeys in handler threads. > > upcall: Revalidate using cache of mask, actions. > > hash: Add 128-bit murmurhash. > > dpif: Add Unique flow identifiers. > > datapath: Add support for OVS_FLOW_ATTR_UID. > > revalidator: Reduce ukey contention. > > revalidator: Distinguish new and duplicate flows. > > upcall: Distinguish duplicate upcalls from conflicts. > > > > datapath/datapath.c | 215 ++++-- > > datapath/flow.h | 12 +- > > datapath/flow_netlink.c | 60 ++ > > datapath/flow_netlink.h | 2 + > > datapath/flow_table.c | 229 +++++- > > datapath/flow_table.h | 5 +- > > datapath/linux/compat/include/linux/openvswitch.h | 29 + > > include/openvswitch/types.h | 5 + > > lib/dpctl.c | 14 +- > > lib/dpif-linux.c | 133 ++-- > > lib/dpif-netdev.c | 144 ++-- > > lib/dpif-provider.h | 9 +- > > lib/dpif.c | 47 +- > > lib/dpif.h | 31 +- > > lib/flow.h | 6 + > > lib/hash.c | 194 ++++- > > lib/hash.h | 4 +- > > lib/odp-util.c | 55 ++ > > lib/odp-util.h | 25 + > > ofproto/ofproto-dpif-upcall.c | 813 > > ++++++++++++++------- > > ofproto/ofproto-dpif-upcall.h | 1 + > > ofproto/ofproto-dpif.c | 93 ++- > > ofproto/ofproto-dpif.h | 2 + > > tests/dpif-netdev.at | 5 + > > tests/ofproto-dpif.at | 28 +- > > tests/ofproto-macros.at | 1 + > > 26 files changed, 1632 insertions(+), 530 deletions(-) > > > > -- > > 1.7.10.4 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev