On Fri, Sep 12, 2014 at 11:24 AM, Jarno Rajahalme <jrajaha...@nicira.com> wrote: > This new flag is useful for suppressing error logging while probing > for datapath features using flow commands. For backwards > compatibility reasons the commands are executed normally, but error > logging is suppressed. > > Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com> I got following warning from patch checker:
linux/checkpatch.pl 0001-datapath-Add-support-for-OVS_FLOW_ATTR_PROBE.patch WARNING: line over 80 characters #64: FILE: datapath/datapath.c:866: + OVS_NLERR(log, "Flow actions attribute not present in new flow."); WARNING: line over 80 characters #139: FILE: datapath/datapath.c:1035: + acts = get_flow_actions(a[OVS_FLOW_ATTR_ACTIONS], &key, &mask, log); WARNING: quoted string split across lines #305: FILE: datapath/flow_netlink.c:361: + OVS_NLERR(log, "Key attribute has unexpected length " + "(type=%d, length=%d, expected=%d).", type, WARNING: quoted string split across lines #365: FILE: datapath/flow_netlink.c:430: + "IPv4 tunnel attribute type has unexpected " + " length (type=%d, length=%d, expected=%d).", WARNING: quoted string split across lines #379: FILE: datapath/flow_netlink.c:481: + "Geneve option length exceeds " + "maximum size (len %d, max %zu).", WARNING: quoted string split across lines #389: FILE: datapath/flow_netlink.c:489: + OVS_NLERR(log, "Geneve option length is not " + "a multiple of 4 (len %d).", WARNING: quoted string split across lines #402: FILE: datapath/flow_netlink.c:515: + "Geneve option key length " + "(%d) is different from mask " WARNING: quoted string split across lines #403: FILE: datapath/flow_netlink.c:516: + "(%d) is different from mask " + "length (%d).", WARNING: quoted string split across lines #735: FILE: datapath/flow_netlink.c:1372: + OVS_NLERR(log, "Flow action size (%u bytes) exceeds maximum " + "(%u bytes)", size, MAX_ACTIONS_BUFSIZE); total: 0 errors, 9 warnings, 886 lines checked Otherwise looks good. Acked-by: Pravin B Shelar <pshe...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
