There¹s a minor issue with this patch: not every option is supported by
every compiler (for example, on my system, clang doesn¹t support -Og).
In this case ovs-dev.py fails to generate a Makefile.
I think we can address this in a separate commit. In the meantime:
Acked-by: Daniele Di Proietto <ddiproie...@vmware.com>
On 9/5/14, 2:20 PM, "Ethan Jackson" <et...@nicira.com> wrote:
>They may or may not make a difference, but there's no reason not to
>support passing them.
>
>Signed-off-by: Ethan Jackson <et...@nicira.com>
>---
> utilities/ovs-dev.py | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
>diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
>index e454e18..3686391 100755
>--- a/utilities/ovs-dev.py
>+++ b/utilities/ovs-dev.py
>@@ -81,7 +81,7 @@ def conf():
> if options.optimize is None:
> options.optimize = 0
>
>- cflags += " -O%d" % options.optimize
>+ cflags += " -O%s" % str(options.optimize)
>
> _sh("./boot.sh")
>
>@@ -362,10 +362,13 @@ def main():
> help="configure the man documentation install
>directory")
> group.add_option("--with-dpdk", dest="with_dpdk",
>metavar="DPDK_BUILD",
> help="built with dpdk libraries located at
>DPDK_BUILD");
>+ parser.add_option_group(group)
>
>- for i in range(4):
>- group.add_option("--O%d" % i, dest="optimize",
>action="store_const",
>- const=i, help="compile with -O%d" % i)
>+ group = optparse.OptionGroup(parser, "Optimization Flags")
>+ for i in ["s", "g"] + range(4) + ["fast"]:
>+ group.add_option("--O%s" % str(i), dest="optimize",
>+ action="store_const", const=i,
>+ help="compile with -O%s" % str(i))
> parser.add_option_group(group)
>
> group = optparse.OptionGroup(parser, "check")
>--
>1.8.1.2
>
>_______________________________________________
>dev mailing list
>dev@openvswitch.org
>https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman/
>listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=MV9BdLjtFIdhBDBaw5z%2BU
>6SSA2gAfY4L%2F1HCy3VjlKU%3D%0A&m=wdCnkkD6JRuPCnkaC%2FTrgAjiJejG5TyWUSe%2FW
>MceSb8%3D%0A&s=ebd1c71c97140711e90b38e6f867fbd2d56390b1928eaf98d6b43eb30a1
>68708
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
