On Tue, Sep 9, 2014 at 1:50 PM, Nithin Raju <nit...@vmware.com> wrote:
> 'sock' is not initialized and hence should not be un-initialized
> as well in the failure path.
>
> Signed-off-by: Nithin Raju <nit...@vmware.com>
Thanks, applied!
> Reported-by: Gurucharan Shetty <shet...@nicira.com>
> ---
> lib/netlink-socket.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
> index a6be186..17e2ea1 100644
> --- a/lib/netlink-socket.c
> +++ b/lib/netlink-socket.c
> @@ -1177,7 +1177,6 @@ static int
> do_lookup_genl_family(const char *name, struct nlattr **attrs,
> struct ofpbuf **replyp)
> {
> - struct nl_sock *sock;
> struct nlmsghdr *nlmsg;
> struct ofpbuf *reply;
> int error;
> @@ -1251,7 +1250,6 @@ do_lookup_genl_family(const char *name, struct nlattr
> **attrs,
> if (!nl_policy_parse(reply, NLMSG_HDRLEN + GENL_HDRLEN,
> family_policy, attrs, ARRAY_SIZE(family_policy))
> || nl_attr_get_u16(attrs[CTRL_ATTR_FAMILY_ID]) == 0) {
> - nl_sock_destroy(sock);
> ofpbuf_delete(reply);
> return EPROTO;
> }
> --
> 1.7.4.1
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
