On 9 September 2014 02:10, Jarno Rajahalme <jrajaha...@nicira.com> wrote:

>
> > On Sep 8, 2014, at 3:23 AM, Joe Stringer <joestrin...@nicira.com> wrote:
> >
> > It's highly unlikely that two flows will hash to the same UID. However,
> > we could handle multiple upcalls from the same flow. If we hash the flow
> > with an additional hash function and the hashes are the same, then the
> > upcalls are most likely from the same flow (assuming that the hash
> > collisions are different for each functions). If the hashes are
> > different, then we have generated the same UID hash for two different
> > flows, and we should log a warning.
>
> I did not look at the patch, but would it be possible to detect a
> duplicate upcall by comparing the flow keys when the hashes collide?
>

 I think that I was trying to avoid this, but thinking again I didn't have
a good reason. This would be much simpler, so I'll make the change for the
next version.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to