Thx Ben,
> It's a little unusual for an initialization function that fails to > still leave the object that it initializes ready to be destroyed. If > upcall_receive() fails, is there other data in 'upcall' that needs to > be destroyed? No, I don't think there is other data to be destroyed.. > If there is, then the other caller of upcall_receive() > is wrong because it does not call upcall_uninit(). If there is not, > then upcall_cb() can simply "return error;" instead of calling > upcall_uninit(). > Makes sense, I'll also add a note to the upcall_receive() comment _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
