Hi Saurabh, I am not a co-Author. As per CONTRIBUTING guidelines even if i am submitting a patch on someone else's behalf i should add my name in Signed-off by. I have categorically mentioned in all the patches that the change is attributed to nithin.
Kindly, let me know if there is any confusion. Regards, Ankur ________________________________________ From: Saurabh Shah Sent: Friday, August 29, 2014 12:23 PM To: Ankur Sharma; Eitan Eliahu; Samuel Ghinet; dev@openvswitch.org; Nithin Raju Subject: RE: [ovs-dev] [PATCH 9/9 v2] datapath-windows: refactor code to setup dump start state > > I have talked to ben and he is fine with the approach of handling the review > comment in another patch in the same series. But yes ideally we should try > to keep the review comment fix in the same patch. > I would go with the reviewers preference. No one likes to block reviews unnecesarily unless they have good reasons. If the left over things are really minor I am sure the reviewer will be more than happy to punt it for future as well. > I have submitted a v3 of the patch which has following changes: > a. Rebasing patch 1/1 > b. Trailing whitespace in 4/4 > c. Removing your name from Acked-by. > > I am fine with the current set of changes and hence they stay as Acked-by: > Ankur Sharma <ankursha...@vmware.com> Since you are the co-author, it doesn't make sense to me that you ack your own patch. Saurabh _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
