On Wed, Aug 13, 2014 at 02:35:19PM -0700, Ethan Jackson wrote: > > I'm not sure of the value of the new 'put_actions' member. It only > > gets used in one place. That place can't compose_slow_path() itself? > > It did before this commit. > > So in the final patch, dpif-netdev will use the put_actions to figure > exactly what to install for slow path actions. An alternative would > be for the upcall callback to somehow indicate that slow path actions > are required, and that it should do the conversion itself. Do you > think that might be cleaner?
No. Having now read the final patch, let's stick with this design for now. > > recv_upcalls() and exec_upcalls() have a lot of code in common. Can > > recv_upcalls() use exec_upcalls() as a helper? > > Yep, this is just an intermediate issue, the very next patch fixes > this. I'd prefer to leave it if that's alright as it makes the diffs > a bit cleaner. OK. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
