On Mon, Aug 04, 2014 at 03:19:16PM +0800, [email protected] wrote: > From: Chunhe Li <[email protected]> > > Only check wheather is daemon pid exist is not enough, becasue the > pid which store in pidfile maybe assign to another process by OS. > So it will checking failed for pid exist, but the starting process > which own the pid is not the ovs daemon. >
The changes from the previous version should be put after the --- so that they do not make it into the change log: > patch v2: > using /proc/$pid/comm check process name, instead of pidof. > > Signed-off-by: Chunhe Li <[email protected]> > Signed-off-by: Wunyunfei <[email protected]> > Signed-off-by: Ben Pfaff <[email protected]> Thanks for v2. Why is there a sign-off by Wunyunfei <[email protected]>? (How did this person contribute?) I believe that this: > +pid_comm_check () { > + if [ "$1" = "`cat /proc/$2/comm`" ]; then > + return 0 > + fi > + > + return 1 > +} can simply be written: pid_comm_check () { [ "$1" = "`cat /proc/$2/comm`" ] } _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
