On Mon, Aug 04, 2014 at 03:19:16PM +0800, lichu...@huawei.com wrote:
> From: Chunhe Li <lichu...@huawei.com>
>
> Only check wheather is daemon pid exist is not enough, becasue the
> pid which store in pidfile maybe assign to another process by OS.
> So it will checking failed for pid exist, but the starting process
> which own the pid is not the ovs daemon.
>
The changes from the previous version should be put after the --- so
that they do not make it into the change log:
> patch v2:
> using /proc/$pid/comm check process name, instead of pidof.
>
> Signed-off-by: Chunhe Li <lichu...@huawei.com>
> Signed-off-by: Wunyunfei <wuyun...@huawei.com>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
Thanks for v2.
Why is there a sign-off by Wunyunfei <wuyun...@huawei.com>? (How did
this person contribute?)
I believe that this:
> +pid_comm_check () {
> + if [ "$1" = "`cat /proc/$2/comm`" ]; then
> + return 0
> + fi
> +
> + return 1
> +}
can simply be written:
pid_comm_check () {
[ "$1" = "`cat /proc/$2/comm`" ]
}
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
