On Wed, Jul 30, 2014 at 02:22:50PM +0800, lichu...@huawei.com wrote: > From: Chunhe Li <lichu...@huawei.com> > > Only check wheather is daemon pid exist is not enough, becasue the pid which > store in pidfile maybe assign to another process by OS. So it will checking > failed for pid exist, but the starting process which own the pid is not the > ovs daemon. > > Signed-off-by: Chunhe Li <lichu...@huawei.com> > Signed-off-by: wuyunfei <wuyun...@huawei.com>
Does this solve a problem you observed in practice? There are at least two other ways that one could verify that the pid is actually the process we expect. One is to look at /proc/$pid/comm or /proc/$pid/exe. The other is to verify that the process holds the lock on the pidfile (which all OVS daemons do). These approaches might be more reliable than "pidof": instead of checking that some process with the given name exists, they check attributes of that particular process. What are your thoughts? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
