Thanks your reply, Could this patch be applied to other branches? Chunhe
>-----Original Message----- >From: Pravin Shelar [mailto:pshe...@nicira.com] >Sent: Thursday, July 31, 2014 4:38 AM >To: Lichunhe >Cc: dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH] vport-internal_dev:Drop packets when interdev is >not up > >On Tue, Jul 29, 2014 at 6:49 PM, <lichu...@huawei.com> wrote: >> From: Chunhe Li <lichu...@huawei.com> >> >> If the internal device is not up, it should drop received packets. >> Sometimes it receive the broadcast or multicast packets, and the ip >> protocol stack will casue more cpu usage wasted. >> >> Signed-off-by: Chunhe Li <lichu...@huawei.com> >> --- >> datapath/vport-internal_dev.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/datapath/vport-internal_dev.c >> b/datapath/vport-internal_dev.c index 3b0f9a7..b0e1b24 100644 >> --- a/datapath/vport-internal_dev.c >> +++ b/datapath/vport-internal_dev.c >> @@ -242,6 +242,11 @@ static int internal_dev_recv(struct vport *vport, >struct sk_buff *skb) >> struct net_device *netdev = netdev_vport_priv(vport)->dev; >> int len; >> >> + if (netdev && !(netdev->flags & IFF_UP)) { >> + kfree_skb(skb); >> + return 0; >> + } >> + >There is no need to check for netdev pointer, so I removed it, added unlikely >annotation and pushed the patch. > >Thanks, >Pravin. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
