On 07/30/2014 12:45 PM, Gurucharan Shetty wrote:
On Wed, Jul 30, 2014 at 11:19 AM, Andrew James <andrew.ja...@hp.com> wrote:
My goal here was to support using OVS with upstart on Debian. I'm certainly
open to the possibility that this belongs in the Debian package more than
here.
Upstream debian package for OVS is maintained by Ben Pfaff and I think
he simply uploads from the openvswitch repo. So I think a different
version just for upstream debian wouldn't work.
I did test this on Debian (without the noted issues). Obviously,
Ubuntu needed testing too (issues confirmed on 12.04, btw). Please let me
know if you target other distributions that use this packaging.
They are the only 2 that I know of.
Are you interested in adding an upstart job file? I'd understand if you
weren't. I can follow up with a more detailed response to the issues you've
noted and a new patch if you are.
I think adding an upstart file is fine as long as the current
/etc/init.d/openvswitch-switch exists.
But I would like to know the use case properly. Why do we need the upstart job?
If it is because we want OVS to start before NFS by default, then that
I think is a bug and will cause problems.
No, no NFS here :)
The use case is Triple O (OpenStack On OpenStack). I'd like to have an upstart
job file available in the package to alleviate the need for an element that cats
out an upstart file:
https://git.openstack.org/cgit/openstack/tripleo-image-elements/tree/elements/network-utils/install.d/70-network-utils
That was added in 7781738f9644b27ae0b8c4f29b9dc2bf32374946 to ensure that OVS
would be running to make a cloud-init meta data server available in time.
If the primary goal is to just emit events for other upstart jobs,
then it would be nice if there is some sort of
integration between the upstart job and /etc/init.d/openvswitch-switch.
(I do not know how upstart jobs work very well, so I may need more
details while you respond.)
I included the events because to enable other upstart jobs to be triggered
by/wait for them. They don't seem to have any downside.
I've looked at the upstart-sysv compatibility guidelines in Debian Policy 9.11.1
(https://www.debian.org/doc/debian-policy/ch-opersys.html#s-upstart) and
https://wiki.ubuntu.com/UpstartCompatibleInitScripts. Unfortunately, these
only apply to Saucy, Jessie or later. Following the guidelines with earlier
releases (due to versions of debhelper) produces the issues you noted previously
(/etc/init.d/openvswitch-switch becoming a link, etc).
Since those releases aren't very old, I'd imagine adding an upstart job file
isn't worth losing compatibility. If someone on-list knows of a workaround,
please let me know. I'll continue to look for one in the mean time.
Following the guidelines also involves short-circuiting the sysv init script
with upstart_is_init. This makes it difficult or impossible to use the sysv init
script from the upstart job. Given that, would a v2 patch be welcome that does
duplicate the start function from the sysv init script?
Thanks,
--
Andrew James
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
