> > > I don't wish to add to any confusion but I will none the less > make a comment on this change which you may choose to ignore if you like. > > The motivation for adding connmgr_wants_packet_in_on_miss() is to help > implement per-OpenFlow version behaviour of packet_in messages. So if > monitors should have per-OpenFlow version behaviour then I am not sure your > patch is correct. My recollection is that this behaviour of monitors seemed > useful for the purpose of testing the per-OpenFlow version behaviour of > packet in messages. But it was a while ago so my recollection may not be > accurate. > > >
Hey Simon, Thanks for the explanation, I think we do want to have per-OpenFlow version 'table-miss' behavior for 'ofctl monitor'. My original understanding was that if there is no established 'ofconn' to controller, connmgr_wants_packet_in_on_miss() should always returns false, and 'ofctl monitor' should not work. After checking the code further, I think we treat 'ofconn' from 'ovs-ofctl monitor' as 'controller' also. And i see why you wrote connmgr_wants_packet_in_on_miss(). So, I'm dropping this patch. Thanks, Alex Wang, _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
