On Fri, Jul 25, 2014 at 04:59:21PM -0700, Justin Pettit wrote: > It might be nice to document that "controllers" only contains primary > controllers. ??The definitions don't provide any distinction between the > various members: > > ?? ?? struct hmap controllers; ?? /* Controller "struct ofconn"s. */ > ?? ?? struct list all_conns; ?? ?? /* Contains "struct ofconn"s. */
Yeah, that's confusing. I changed the comments to: struct hmap controllers; /* All OFCONN_PRIMARY controllers. */ struct list all_conns; /* All controllers. */ > However, overall: > > Acked-by: Justin Pettit <jpet...@nicira.com> Thanks! _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev