Thanks, I added a sentence to the commit message and pushed to master.
On Fri, Jul 25, 2014 at 08:57:50AM -0700, Justin Pettit wrote:
> It might be worth making it a bit more explicit that this makes the log level
> match the same message in BFD.
>
> Acked-by: Justin Pettit <jpet...@nicira.com>
>
> --Justin
>
>
> On July 24, 2014 at 1:29:48 PM, Ben Pfaff (b...@nicira.com) wrote:
> > These messages can cause the testsuite to fail on a busy build machine
> > since the testsuite treats WARN or ERR log messages as failures.
> >
> > Alternatively, the testsuite could ignore "long delay" messages (it ignores
> > some other categories of messages). In that case I'd expect that we'd
> > want to change BFD to match CFM since I don't know of a reason why they
> > should log differently.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/cfm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/cfm.c b/lib/cfm.c
> > index 7784369..d83a68c 100644
> > --- a/lib/cfm.c
> > +++ b/lib/cfm.c
> > @@ -613,7 +613,7 @@ cfm_compose_ccm(struct cfm *cfm, struct ofpbuf *packet,
> > if (cfm->last_tx) {
> > long long int delay = time_msec() - cfm->last_tx;
> > if (delay > (cfm->ccm_interval_ms * 3 / 2)) {
> > - VLOG_WARN("%s: long delay of %lldms (expected %dms) sending CCM"
> > + VLOG_INFO("%s: long delay of %lldms (expected %dms) sending CCM"
> > " seq %"PRIu32, cfm->name, delay, cfm->ccm_interval_ms,
> > cfm->seq);
> > }
> > --
> > 1.7.10.4
> >
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
