An error from nl_sock_recv() could mean that there issues with the netlink
socket (EBADF, ENOTSOCK, ...). Keeping calling nl_sock_recv() in this case is
harmful: nln_run() will never return and, since we are calling it from the main
thread, vswitchd will become unresponsive.

Suggested-by: Alex Wang <al...@nicira.com>
Signed-off-by: Daniele Di Proietto <ddiproie...@vmware.com>
---
 lib/netlink-notifier.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/netlink-notifier.c b/lib/netlink-notifier.c
index 9aa185d..08e3c07 100644
--- a/lib/netlink-notifier.c
+++ b/lib/netlink-notifier.c
@@ -188,6 +188,7 @@ nln_run(struct nln *nln)
                              ovs_strerror(error));
             }
             nln_report(nln, NULL);
+            return;
         }
     }
 }
-- 
2.0.0

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to