Thanks, The reason I didn’t do that in the first place is that test-cmap is already taking 55s to run on my machine, and I thought that adding other code to check_cmap() might increase runtime significantly (we call check_cmap() a lot and cmap_next_position() is slow).
After applying your suggestion, it turns out this is not the case: it takes about 80s. If you think this is an acceptable runtime (I think it’s ok), I’m about to send v2. Daniele On Jul 16, 2014, at 9:30 AM, Ben Pfaff <b...@nicira.com> wrote: > On Tue, Jul 15, 2014 at 09:57:55PM -0700, Daniele Di Proietto wrote: >> cmap_next_position() didn't update the node pointer while iterating through a >> list of nodes with the same hash. >> This commit fixes the bug and improve test-cmap to detect it. >> >> Signed-off-by: Daniele Di Proietto <ddiproie...@vmware.com> > > Good catch. > > I think that it would be better to always try iterating both ways in > check_cmap(), rather than just one way on each call. Will you modify > the patch to do that? > > Thanks, > > Ben _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
