[ovs-dev] [clang 1/4] ofp-util: Fix null pointer dereference in ofputil_pull_buckets().

[Ben Pfaff]

Found by clang-analyzer.

Signed-off-by: Ben Pfaff <b...@nicira.com>
---
 lib/ofp-util.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 6d551ad..a4ee2c2 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -6986,6 +6986,7 @@ ofputil_pull_buckets(struct ofpbuf *msg, size_t 
buckets_length,
         if (!ob) {
             VLOG_WARN_RL(&bad_ofmsg_rl, "buckets end with %"PRIuSIZE" leftover 
bytes",
                          buckets_length);
+            return OFPERR_OFPGMFC_BAD_BUCKET;
         }
 
         ob_len = ntohs(ob->len);
-- 
1.7.10.4

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev