LGTM, Acked-by: Alex Wang <al...@nicira.com>
On Thu, Jul 10, 2014 at 2:46 PM, Ben Pfaff <b...@nicira.com> wrote:
> Commit 8f20fd98db (netlink-socket: Work around upstream kernel Netlink
> bug.) got the sign of the error code wrong, so that it reported e.g. -22
> for EINVAL to nl_sock_recv__()'s caller, instead of 22.
>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> lib/netlink-socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
> index c5f3802..42ba7e1 100644
> --- a/lib/netlink-socket.c
> +++ b/lib/netlink-socket.c
> @@ -338,7 +338,7 @@ nl_sock_recv__(struct nl_sock *sock, struct ofpbuf
> *buf, bool wait)
> error = (retval < 0 ? errno
> : retval == 0 ? ECONNRESET /* not possible? */
> : nlmsghdr->nlmsg_len != UINT32_MAX ? 0
> - : -retval);
> + : retval);
> } while (error == EINTR);
> if (error) {
> if (error == ENOBUFS) {
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
