On 07/09/14 at 03:22pm, Daniele Di Proietto wrote:
> match_validate() enforce that a mask matching on NDP attributes has also an
> exact match on ICMPv6 type.
> The ICMPv6 type, which is 8-bit wide, is stored in the 'tp.src' field of
> 'struct sw_flow_key', which is 16-bit wide.
> Therefore, an exact match on ICMPv6 type should only check the first 8 bits.
> 
> This commit fixes a bug that prevented flows with an exact match on NDP field
> from being installed
> 
> Signed-off-by: Daniele Di Proietto <ddiproie...@vmware.com>

Using 0xff is obviously correct but wouldn't this break ABI for users with
existing 0xffff masks? How about allowing both?
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to