On Wed, Jul 2, 2014 at 4:24 PM, Pritesh Kothari (pritkoth)
<pritk...@cisco.com> wrote:
> Thanks for the review.
>
>>> + OVS_GREP_IFELSE([$KSRC/include/linux/if.h], [IFF_LIVE_ADDR_CHANGE])
>>> +
>>> OVS_GREP_IFELSE([$KSRC/include/linux/if_vlan.h], [vlan_set_encap_proto])
>>>
>> Why are you changing existing compat code in this patch? Even if you
>> have a reason for such change please send separate patch with the
>> explanation.
>
> Sure.
>
>>
>> @@ -322,11 +329,17 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [
>>> OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [skb_get_hash])
>>> OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [skb_clear_hash])
>>> OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [l4_rxhash])
>>> + OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [encapsulation])
>>>
>> I think better way to search for encap is searching for GRE offload
>> feature, I done same check in patch that I posted "datapath: Enable
>> tunnel GSO features.”
>
> will do.
>
>>> -#endif /* 3.12 */
>>> +struct sk_buff *iptunnel_handle_offloads(struct sk_buff *skb,
>>> + bool csum_help,
>>> + int gso_type_mask)
>>> +{
>>> + int err;
>>> +
>> This function is not called from any other function in OVS. why do you
>> want to add it to ovs compat layer?
>
> actually gre_handle_offloads calls it, will see if i can figure out a way to
> not to include this.
>
If gre_handle_offloads() is available then we do not need to define
any lower level API, If it is not there is compat
gre_handle_offloads() which does not call this function. Therefore
there is no need to define it.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
