On Wed, Jun 25, 2014 at 5:04 PM, Ben Pfaff <b...@nicira.com> wrote: > On Tue, Jun 10, 2014 at 2:06 PM, Alessandro Pilotti > <apilo...@cloudbasesolutions.com> wrote: >> https://github.com/cloudbase/openvswitch-hyperv >> https://github.com/cloudbase/openvswitch-hyperv-kernel > > Thanks a lot for sending this out. I've just now started taking a > first look at it. > > I see that there are 216 commits beyond the base OVS code. I hope that you > are planning to reduce the number. It is not really practical to review them > individually when they are organized that way. (It's not going to stop me > from > an initial review--I'll just read the overall diff.)
Actually it's very difficult to read the overall diff, which randomly changes lots of files: 509 files changed, 109551 insertions(+), 47618 deletions(-) It also adds all of the headers from openssl and a windows pthread library, plus binaries for both libraries. I think you're going to need to clean this up a lot to make it reviewable. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev