Hey Thomas,
Sorry for this very delayed reply and thanks a lot for your close review!
Please see my comments inline,
> > +
> > +#define MAX_CPU_SOCKETS 8
>
> Can we bump this to something like 128? SPARC64 and the like have
> been pretty crazy on the subject of number of sockets. It shouldn't
> hurt as you break out of the loop anyway upon the first NULL
> eturn of opendir().
>
Yes, I raised it to 128.
>
> > +
> > + while ((subdir = readdir(dir)) != NULL) {
>
> Maybe use readdir_r() just to be safe for the future? It would also
> allow you to handle error conditions correctly.
>
>
I'll use readdir_r().
> > + for an unpinned core. Returns the core_id
> > + * if found and set the 'core->pinned' to true. Otherwise, returns -1.
> */
> > +int
> > +ovs_numa_get_unpinned_core_any(void)
>
> How about defining this as uint32_t to be consistent ...
>
>
I'll change to use int and define the macro
#define OVS_CORE_UNSPEC INT_MAX
Also, fixed all typo and indentation issue. thx.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
