On Tue, Jun 24, 2014 at 11:09:48AM -0700, Ben Pfaff wrote:
> On Wed, Jun 18, 2014 at 10:14:30PM -0300, Flavio Leitner wrote:
> > Add IGMP info to struct flow, flow compose and flow extract.
> >
> > Signed-off-by: Flavio Leitner <f...@redhat.com>
> > ---
> > lib/flow.c | 22 ++++++++++++++++++++--
> > lib/flow.h | 11 ++++++-----
> > lib/match.c | 8 +++++++-
> > lib/nx-match.c | 2 +-
> > lib/odp-util.h | 2 +-
> > lib/ofp-util.c | 2 +-
> > ofproto/ofproto-dpif-xlate.c | 2 +-
> > 7 files changed, 37 insertions(+), 12 deletions(-)
>
> I think that the comment in struct flow about "keep last" isn't
> working. At least twice the members have been updated without keeping
> the comment, at least, last. I'm folding this in:
>
> diff --git a/lib/flow.h b/lib/flow.h
> index 50e98cb..2ca7e27 100644
> --- a/lib/flow.h
> +++ b/lib/flow.h
> @@ -121,9 +121,9 @@ struct flow {
> ovs_be16 tp_src; /* TCP/UDP/SCTP source port. */
> ovs_be16 tp_dst; /* TCP/UDP/SCTP destination port. */
> ovs_be32 igmp_group_ip4; /* IGMP group IPv4 address */
> - /* Keep last for the BUILD_ASSERT_DECL below
> */
> uint32_t dp_hash; /* Datapath computed hash value. The exact
> - computation is opaque to the user space.*/
> + * computation is opaque to the user space.
> + * Keep last for BUILD_ASSERT_DECL below. */
> };
> BUILD_ASSERT_DECL(sizeof(struct flow) % 4 == 0);
Sure, no problem.
Thanks
fbl
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
