On Tue, Jun 24, 2014 at 9:46 AM, Gurucharan Shetty <shet...@nicira.com> wrote: > On Mon, Jun 23, 2014 at 11:51 AM, Ben Pfaff <b...@nicira.com> wrote: >> On Fri, Jun 13, 2014 at 07:40:02AM -0700, Gurucharan Shetty wrote: >>> There is no 'kill -l' type functionality available on Windows. >>> So instead of looking for the string 'ABRT', check for the exit >>> code in both platforms. On msys (unit test environment), it is 9 >>> and on Linux, it is 134 (SIGABRT + 128). >>> >>> On Windows, stderr is fully buffered if connected to a pipe. >>> Make it _IONBF so that an abort does not miss log contents. >>> >>> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com> >> >> Can we add a comment about why we're un-buffering stderr here? Also I >> think we might as well just do it unconditionally (not just on >> Windows) because POSIX doesn't define the circumstances in which >> stderr is fully buffered (it predicates it on what is an "interactive >> device" but doesn't define that term). > Okay. I will add the following incremental before pushing it.
Thanks! _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
