Acked-by: Ethan Jackson <et...@nicira.com>
On Mon, Jun 9, 2014 at 4:41 PM, Thomas Graf <tg...@suug.ch> wrote: > On 06/05/14 at 10:02pm, Ben Pfaff wrote: >> When a flow with a "learn" action is deleted, one often wants the flows >> that it created (the "learned flows") to be deleted as well. This commit >> makes that possible. >> >> I am aware of a race condition that could lead to a learned flow not being >> properly deleted. Suppose thread A deletes a flow with a "learn" action. >> Meanwhile, thread B obtains the actions for this flow and translates and >> executes them. Thread B could obtain the actions for the flow before it is >> deleted, but execute them after the "learn" flow and its learned flows are >> deleted. The result is that the flow created by thread B persists despite >> its "learn" flow having been deleted. This race can and should be fixed, >> but I think that this commit is worth reviewing without it. > > Code looks good aside from the race condition. Happy to provide my > ACK for the code as-is > > Acked-by: Thomas Graf <tg...@suug.ch> > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
