Thanks for pointing them out. I will work on a patch. On Thu, Jun 12, 2014 at 10:03 AM, Ben Pfaff <[email protected]> wrote: > In datapath/datapath.c, queue_userspace_packet() calls > ovs_nla_put_flow() but ignores the return value.
I suppose if the buffer size is always big enough, we don't have to return error. In light of the bug mentioned below, we should either check the return value or assert. At the same time, > key_attr_size() seems not to include space for OVS_KEY_ATTR_DP_HASH > and OVS_KEY_ATTR_RECIRC_ID (just the first two I noticed, I didn't > keep looking). It seems like a bug to me. > Yes, I missed them when adding recirc. Will review for other fields. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
