On 06/06/14 at 02:59pm, Ben Pfaff wrote: > I only changed it for cosmetic reasons, because I thought that the > code "looked better" that way, so that's a good question. > > I do not think that the order matters because both of these are used > only with ofproto_mutex held: > > * The list of meter rules is mainly used to determine which > rules must be deleted when a meter is deleted, which only > happens when ofproto_mutex is held. > > (I see that handle_meter_request() breaks this rule. We > shall have to fix this. Also we ought to annotate 'rules' > with OVS_GUARDED_BY.) > > * The eviction groups are only used during flow_mods, which > hold ofproto_mutex anyway. > > (We could use better annotations here too.)
Makes sense Acked-by: Thomas Graf <t...@suug.ch> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
