On 06/04/14 at 08:53am, Simon Horman wrote: > If an MPLS packet requires segmentation then use mpls_features > to determine if the software implementation should be used. > > As no driver advertises MPLS GSO segmentation this will always be > the case. > > I had not noticed that this was necessary before as software MPLS GSO > segmentation was already being used in my test environment. I believe that > the reason for that is the skbs in question always had fragments and the > driver I used does not advertise NETIF_F_FRAGLIST (which seems to be the > case for most drivers). Thus software segmentation was activated by > skb_gso_ok(). > > This introduces the overhead of an extra call to skb_network_protocol() > in the case where where CONFIG_NET_MPLS_GSO is set and > skb->ip_summed == CHECKSUM_NONE. > > Thanks to Jesse Gross for prompting me to investigate this. > > Signed-off-by: Simon Horman <ho...@verge.net.au> > Acked-by: YAMAMOTO Takashi <yamam...@valinux.co.jp>
LGTM Acked-by: Thomas Graf <tg...@suug.ch> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
