Acked-by: YAMAMOTO Takashi <yamam...@valinux.co.jp>
> Me too. > > Acked-by: Ben Pfaff <b...@nicira.com> > > > On Tue, Jun 03, 2014 at 02:22:48PM -0700, Jarno Rajahalme wrote: >> This better, >> >> Acked-by: Jarno Rajahalme <jrajaha...@nicira.com> >> >> On Jun 3, 2014, at 2:20 PM, Gurucharan Shetty <shet...@nicira.com> wrote: >> >> > May be we should add a new TODO section in BUILD.Windows like: >> > >> > diff --git a/BUILD.Windows b/BUILD.Windows >> > index ca0d252..41e6eab 100644 >> > --- a/BUILD.Windows >> > +++ b/BUILD.Windows >> > @@ -85,3 +85,11 @@ For example, >> > --with-openssl="C:/OpenSSL-Win32" >> > >> > * Run make for the ported executables. >> > + >> > +TODO: >> > +---- >> > + >> > +* OVS currently has no native support for atomics on Windows. Pthreads >> > +are used as a fallback, but some features, such as OVS-RCU are really >> > +slow without native atomics support. Atomics support for Windows has to >> > +be brought in. >> > >> > On Tue, Jun 3, 2014 at 2:16 PM, Jarno Rajahalme <jrajaha...@nicira.com> >> > wrote: >> >> >> >> On Jun 3, 2014, at 2:03 PM, Ben Pfaff <b...@nicira.com> wrote: >> >> >> >>> On Tue, Jun 03, 2014 at 01:09:11PM -0700, Jarno Rajahalme wrote: >> >>>> OVS is slow when compiled with pthreads atomics. Add a generic note >> >>>> in INSTALL, with a reference to lib/ovs-atomic.h, where a new comment >> >>>> provides additional detail. >> >>>> >> >>>> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com> >> >>> >> >>> I think this is only likely to affect Windows (everyone else uses GCC >> >>> or Clang) so should we put it in BUILD.Windows? >> >> >> >> >> >> So you think this should not be mentioned in INSTALL? If so, I think the >> >> text there should be modified to something like ?* GCC 4.x or clang C >> >> compiler? instead of the current ?A C compiler, such as??. >> >> >> >> How about adding the following to BUILD.Windows: >> >> >> >> diff --git a/BUILD.Windows b/BUILD.Windows >> >> index ca0d252..05956ba 100644 >> >> --- a/BUILD.Windows >> >> +++ b/BUILD.Windows >> >> @@ -39,6 +39,10 @@ project from >> >> ftp://sourceware.org/pub/pthreads-win32/prebuilt-dll-2-9-1-release to a >> >> directory (e.g.: C:/pthread). >> >> >> >> +OVS currently has no native support for atomics on Windows. Pthreads >> >> +are used as a fallback, but some features, such as OVS-RCU are really >> >> +slow without native atomics support. >> >> + >> >> * Get the Open vSwitch sources from either cloning the repo using git >> >> or from a distribution tar ball. >> >> >> >> Jarno >> >> >> >> _______________________________________________ >> >> dev mailing list >> >> dev@openvswitch.org >> >> http://openvswitch.org/mailman/listinfo/dev >> > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
