Addressed all these style comments in v5. Ryan
On 5/27/14 3:00 PM, "Ethan Jackson" <et...@nicira.com> wrote: >Couple of minor style comments on my end. > >I'd prefer if xlate_init_new_xcfg() and set_new_cfg() are renamed to >something like xlate_txn_start() and xlate_txn_commit(). From the >callers perspecdtive we're creating a transaction with which we change >the configuration. It's a bit more obvious what's going on. > >We're implicitly enforcing that only one transaction is allowed at a >time. Therefore, I'd like the transaction start function to assert >that new_xcfg is NULL. > >There's a bunch of functions where the xlate_cfg is the last argument >which would be a bit more in keeping with the style if it was the >first argument. > >Also there's a bunch of functions where we ovsrcu_get the xlate >config. This isn't technically part of the coding style, but most of >the code puts variable definitions which are assignments first, and >usually in longest to shortest order. I.E. that should be the first >variable assignment in the function. > >Patch looks good to me. > >Acked-by: Ethan Jackson <et...@nicira.com> > > >On Thu, May 22, 2014 at 7:03 PM, Alex Wang <al...@nicira.com> wrote: >> Hey Ben, >> >> Could you review it? Should be all ready, >> >> >> Thanks, >> Alex Wang, >> >> >> On Tue, May 20, 2014 at 11:19 AM, Ben Pfaff <b...@nicira.com> wrote: >>> >>> On Tue, May 20, 2014 at 11:04 AM, Ryan Wilson 76511 <wr...@vmware.com> >>> wrote: >>> > Per Alex's request, I ran a 10K internal port creation test (using >>> > batches >>> > of 500 ports at a time via ovs-vsctl) on my 8GB memory machine. Again >>> > RCU >>> > was slightly faster: >>> > >>> > master: real 3m28.301s >>> > with RCU: real 3m21.489s >>> >>> OK, that's reassuring. If O(n**2) behavior is going to show up, it's >>> going to be at higher scale, then, and so I won't worry about it for >>> now since scale always requires a little bit of extra work. >>> _______________________________________________ >>> dev mailing list >>> dev@openvswitch.org >>> >>>https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailma >>>n/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=TfBS78Vw3dzttvXidhb >>>ffg%3D%3D%0A&m=sN1oPAEQ6sHLlViS9K9Pk5InbfXKm0VSiVmPgQPlWj4%3D%0A&s=5a48b >>>c570722284dcc9790f747722f1a056b73e0bbb989ec633aa366d64f709f >> >> >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> >>https://urldefense.proofpoint.com/v1/url?u=http://openvswitch.org/mailman >>/listinfo/dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=TfBS78Vw3dzttvXidhbff >>g%3D%3D%0A&m=sN1oPAEQ6sHLlViS9K9Pk5InbfXKm0VSiVmPgQPlWj4%3D%0A&s=5a48bc57 >>0722284dcc9790f747722f1a056b73e0bbb989ec633aa366d64f709f >> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
