On Thu, May 22, 2014 at 11:16 AM, Ben Pfaff <b...@nicira.com> wrote:
> On Thu, May 22, 2014 at 11:04:41AM -0700, Andy Zhou wrote:
>> Signed-off-by: Andy Zhou <az...@nicira.com>
>
> I usually put an outer set of parentheses on multiline expressions.
Thanks for mentioning this. Plan to push with the following incremental.
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index 5b0791f..5ab1f7f 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -876,11 +876,11 @@ bucket_is_alive(const struct xlate_ctx *ctx,
return false;
}
- return !ofputil_bucket_has_liveness(bucket)
- || (bucket->watch_port != OFPP_ANY
+ return (!ofputil_bucket_has_liveness(bucket)
+ || (bucket->watch_port != OFPP_ANY
&& odp_port_is_alive(ctx, bucket->watch_port))
- || (bucket->watch_group != OFPG_ANY
- && group_is_alive(ctx, bucket->watch_group, depth + 1));
+ || (bucket->watch_group != OFPG_ANY
+ && group_is_alive(ctx, bucket->watch_group, depth + 1)));
}
>
> Acked-by: Ben Pfaff <b...@nicira.com>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
