On Thu, May 22, 2014 at 09:12:09AM -0700, Gurucharan Shetty wrote:
> On Fri, Apr 25, 2014 at 10:24 AM, Ben Pfaff <b...@nicira.com> wrote:
> > The test added in this commit would have caught the bug fixed by commit
> > 96be8de595150 (bridge: When ports disappear from a datapath, add them
> > back.). With that commit reverted, the new test fails.
> >
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
>
> > - error = get_port_by_number(dp, port_no, &port);
> > - if (error) {
> > - return error;
> > - }
> > -
> > hmap_remove(&dp->ports, &port->node);
> > seq_change(dp->port_seq);
> > if (netdev_is_pmd(port->netdev)) {
> > @@ -876,7 +877,6 @@ do_del_port(struct dp_netdev *dp, odp_port_t port_no)
> > }
> >
> > port_unref(port);
> Dont we need any mutex for unref above?
do_del_port() has to be called holding dp->port_mutex (this seems to
be properly annotated).
> > - return 0;
> > }
> >
>
> I did not compile test it because it does not apply right now. But the
> logic looks right.
>
> Acked-by: Gurucharan Shetty <gshe...@nicira.com>
Thanks.
Because of the changes on master in the meantime I will post a v2 in
case you do want another look.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
