On Thu, May 01, 2014 at 01:22:19PM +0300, Alexandru Copot wrote:
> This is only the communication part of the bundles functionality.
> The actual message pre-validation and commits are not implemented.
> 
> We also enable OF1.4 for all the tests.
> 
> Signed-off-by: Alexandru Copot <alex.miha...@gmail.com>
> Cc: Daniel Baluta <dbal...@ixiacom.com>

> ---
> v5:
>   * fold tests patch
>   * add ofputil_encode_bundle_add()
>   * remove duplicate header in OFPRAW_OFPT14_BUNDLE_ADD_MESSAGE comment
>   * return error on commit
>   * check inner message size in ofputil_decode_bundle_add()

The check you added assert-fails upon decoding a message with an invalid
inner length.  That's not acceptable because it allows a controller to
crash the switch.  It needs to instead report an error to the caller.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to