On Apr 21, 2014, at 6:08 PM, YAMAMOTO Takashi <yamam...@valinux.co.jp> wrote:
>> >> On Apr 20, 2014, at 7:49 PM, YAMAMOTO Takashi <yamam...@valinux.co.jp> wrote: >> >>>> + hash = mhash_finish(hash, 13); /* No need to match byte length >>>> here. */ >>> >>> is it worth being special? >>> >> >> I知 not exactly sure what you ask here, but in general, the length parameter >> is used to distinguish between inputs that would otherwise seem the same >> after being padded to 32-bit length for mash_add(). This is not a concern >> here, so the actual value of the second parameter to mhash_finish() is >> inconsequential. > > i wonder if it's worth to depend on the hash algo details > as it doesn't seem to cost much to provide the correct byte length. > I changed the finish number to “42” with a comment “/* Arbitrary number. */“ to stress the fact that it is not the byte length in either case. Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
