On Wed, Apr 23, 2014 at 09:36:30AM +1200, Joe Stringer wrote: > On 23 April 2014 06:19, Ben Pfaff <b...@nicira.com> wrote: > > > > +Please read SubmittingPatches and CodingStyle in the top of the source > > > > SubmittingPatches -> CONTRIBUTING > > > +OpenFlow Group Bucket Stats > > +--------------------------- > > + > > +When OpenFlow group support was added, we forgot to support statistics > > +for individual buckets. xlate_group_bucket() in > > +ofproto/ofproto-dpif-xlate.c appears to be where we need to increment > > +the counters, in the case where ctx->xin->resubmit_stats is > > +nonnull. See the ovs-dev thread starting here: > > +http://openvswitch.org/pipermail/dev/2014-January/036107.html > > > If this involves resubmit_stats, then it would also need a new xc_type. The > xlate_group_bucket() code would add an entry to ctx->xin->xcache if it is > nonnull. > This would also need to follow the code in xlate_push_stats() and > xlate_cache_clear() for the new xc_type. > > > Acked-by: Joe Stringer <joestrin...@nicira.com>
Thanks. I applied both of those changes (I actually just added the text you provided in the second case) and applied this to master. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
