On Tue, Apr 8, 2014 at 9:43 PM, Thomas Graf <tg...@redhat.com> wrote:
> On 04/08/2014 12:00 AM, Pravin wrote:
>>
>> diff --git a/datapath/flow_table.c b/datapath/flow_table.c
>> index 159572b..75c1b82 100644
>> --- a/datapath/flow_table.c
>> +++ b/datapath/flow_table.c
>> @@ -259,11 +259,11 @@ skip_flows:
>> __table_instance_destroy(ti);
>> }
>>
>> -void ovs_flow_tbl_destroy(struct flow_table *table, bool deferred)
>> +void ovs_flow_tbl_destroy(struct flow_table *table)
>> {
>> - struct table_instance *ti = ovsl_dereference(table->ti);
>> + struct table_instance *ti = (struct table_instance __force
>> *)table->ti;
>
>
> Any way we can avoid the __force? Otherwise it deserves at
> least a comment ;-)
It is called from error case or from RCU callback. These is no easy
way to avoid it. I will add a comment.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
