> On Wed, Apr 02, 2014 at 01:19:57PM +0900, YAMAMOTO Takashi wrote: >> Without this change, I observed that >> "ofproto-dpif - ofproto-dpif-monitor 2" test, >> which merely accesses ovsdb, failed in OVS_VSWITCHD_STOP's >> "ovs-appctl -t ovs-vswitchd exit". >> >> Signed-off-by: YAMAMOTO Takashi <yamam...@valinux.co.jp> > > The daemonization sequence is supposed to make sure that the pidfile is > created before the parent process exits. You can see the intent by > looking at daemonize_start() and daemonize_complete(). In > daemonize_start(), the 'if (detach)' block shows that the parent process > is supposed to wait until the child process signals that it has > completed startup before exiting. Later in daemonize_start(), the child > creates the pidfile. In daemonize_complete(), called later, the child > notifies the parent, via fork_notify_startup(), that it has finished > startup and that the parent may exit. > > Thus, I'm surprised that this makes a difference, and if it does that > may indicate a bug in the daemon.c code.
i was not aware of the code. thanks for pointing out. i withdraw this patch for now and take a deeper look next time it happens. YAMAMOTO Takashi > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
