On Fri, Mar 28, 2014 at 9:58 AM, Ben Pfaff <b...@nicira.com> wrote:
> On Fri, Mar 28, 2014 at 09:10:45AM -0700, Gurucharan Shetty wrote:
>> For Windows, use a kernel assigned localhost TCP port to listen for
>> runtime management connections and then write it into a file
>> so that a client can read it and then make a TCP connection.
>>
>> Since we do not have the infrastructure to create pidfiles on
>> windows as of now, we create the *.ctl file without a pid. This
>> should be okay since we use different OVS_RUNDIR when we run
>> multiple copies of a daemon.
>>
>> We do not generate man pages on Windows. But we still update them
>> for Windows so that anyone can read it elsewhere. Since we do not
>> generate it directly, we cannot dynamically show the configured
>> OVS_RUNDIR in windows. So, I have a not so nice \fIOVS_RUNDIR\fR
>> in the man page.
>>
>> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>
>
> This is a nice solution. I think that it is cleaner than other ideas
> I have heard.
>
> I'm not sure why the code opens the file in "a+" mode and then
> truncates it. Wouldn't using plain "w" mode have that effect all in
> one?
You are correct. I will do that.
>
> There's a typo for "absolute" here:
>> + * On Windows, connects to a localhost TCP port as written inside 'path'.
>> + * 'path' should be an absoulte path of the file.
I will correct it.
>
> Acked-by: Ben Pfaff <b...@nicira.com>
Thanks. I will push the changes in sometime.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
