On Mar 25, 2014, at 10:11 AM, Pravin Shelar <pshe...@nicira.com> wrote:
> On Mon, Mar 24, 2014 at 11:56 AM, Jarno Rajahalme <jrajaha...@nicira.com>
> wrote:
...
>> @@ -809,23 +809,21 @@ static int ovs_flow_cmd_new_or_set(struct sk_buff
>> *skb, struct genl_info *info)
>> goto error;
>>
>> /* Validate actions. */
>> - if (a[OVS_FLOW_ATTR_ACTIONS]) {
>> - acts =
>> ovs_nla_alloc_flow_actions(nla_len(a[OVS_FLOW_ATTR_ACTIONS]));
>> - error = PTR_ERR(acts);
>> - if (IS_ERR(acts))
>> - goto error;
>> + error = -EINVAL;
> No need to set error again.
Actually, the error is 0 at this point, due to an immediately preceding check,
and error needs to be set for the next goto, right below:
>
>> + if (!a[OVS_FLOW_ATTR_ACTIONS])
>> + goto error;
>>
…
> otherwise looks good.
> Acked-by: Pravin B Shelar <pshe...@nicira.com>
>
I’ll still send a new version, due to the other changes in the series affecting
this one, too.
Jarno
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
