On Tue, Mar 25, 2014 at 9:41 AM, Flavio Leitner <f...@redhat.com> wrote:
> It should be an administrator task to bring up devices as they
> are configured properly.
>
> Currently, Fedora is deleting the bridges when the interface is
> brought down. Therefore, there is no bridge on the next boot and
> the initscripts can apply the networking configuration properly
> for a new bridge.
>
> However, if the system didn't execute ifdown for some reason, the
> bridge is left in the ovsdb and since internal ports are brought
> up by default, there is no way for initscripts to known if the
> adminitrator has configured it or not already.
>
> This patch partially reverts the commit
> bef071a5fdf8e2dd87677b04b3cf7a8f5094edcb
>
> Signed-off-by: Flavio Leitner <f...@redhat.com>
> ---
> vswitchd/bridge.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index db85856..b2a81a7 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/bridge.c
> @@ -1446,8 +1446,7 @@ iface_do_create(const struct bridge *br,
> VLOG_INFO("bridge %s: added interface %s on port %d",
> br->name, iface_cfg->name, *ofp_portp);
>
> - if ((port_cfg->vlan_mode && !strcmp(port_cfg->vlan_mode, "splinter"))
> - || iface_is_internal(iface_cfg, br->cfg)) {
> + if (port_cfg->vlan_mode && !strcmp(port_cfg->vlan_mode, "splinter")) {
> netdev_turn_flags_on(netdev, NETDEV_UP, NULL);
> }
>
> This looks ok to me, though it does change the behavior of the internal
ports here. Should there be a NEWS entry for this to alert users?
Acked-by: Kyle Mestery <mest...@noironetworks.com>
> --
> 1.8.5.3
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
