On Wed, Mar 12, 2014 at 11:21:19AM -0700, Gurucharan Shetty wrote:
> There are a few structure definitions that is used from
> these headers. The keyword "__packed" has been removed
> from the headers as the corresponding Linux headers don't
> do packing.
> 
> Signed-off-by: Gurucharan Shetty <gshe...@nicira.com>

Would you mind removing the tests on _KERNEL?

The OVS byte order tests are a little different from the BSD ones.
Instead of:
        #if BYTE_ORDER == BIG_ENDIAN
the OVS test should be
        #ifdef WORDS_BIGENDIAN
although it looks like one might better #include "byte-order.h" and then
use CONSTANT_HTONx().

I think I would delete everything in the "#ifdef ICMP6_STRINGS" block.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to