Thanks Ben for the review~, For some reason, the context didn't show up. But I think I know where you are talking about. lib/dpif.c
Please let me know if there is need to modify and refine. I'd like to go over and over to make the API and comments comprehensible. ;D The comment on dpif_port_get_pid() says that the 'hash' parameter > should be a 5-tuple hash. Does it have be calculated a specific way? > No, it does not have to. I want my comment to provide an example of using "5-tuple hash". When designing, I also thought of passing in the "struct flow" so user can define how to choose handler based on the flow themselves. But I thought adding such dependency to the generic api is not good and dropped it. I modified the comments to be more clear. > This appears to delete the comment on dpif_recv_set(), instead of > updating it. In particular I don't know exactly what 'n_handlers' > means. > I forgot to add the comment for this one. added it. It isn't clear to me where the 'handler_id's come from. > I modified the comments to be more clear. > > I noticed that new comments talk about "multiple clients", meaning > multiple threads reading packets from a single "struct dpif *". Old > comments also talked about multiple clients, but they meant different > "struct dpif *"s (often from different processes) referring to a > single datapath. I'm appending an incremental that tries to clarify > that. My incremental also makes the suggestions for handling multiple threads more specific; I'm not sure that my more specific suggestions > are actually what you mean, so please clarify if I misunderstood. > > Thanks Ben, the clarification makes sense to me, will fold in the V2.
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
