On Wed, Jan 08, 2014 at 09:48:45AM -0800, Pravin Shelar wrote:
> I found atomic_init without destroy for following var.
> clock->slow_path

That one doesn't have a call to atomic_destroy() because the timeval
module doesn't ever get uninitialized.

> rule->ref_count

Thanks.  I folded this in:

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 028b07a..f651374 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -2578,6 +2578,7 @@ ofproto_rule_destroy__(struct rule *rule)
     cls_rule_destroy(CONST_CAST(struct cls_rule *, &rule->cr));
     rule_actions_unref(rule->actions);
     ovs_mutex_destroy(&rule->mutex);
+    atomic_destroy(&rule->ref_count);
     rule->ofproto->ofproto_class->rule_dealloc(rule);
 }
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to