On 07.01.2014 4:16, Jesse Gross wrote:
From: Ben Pfaff <b...@nicira.com>
We won't normally have a ton of flow masks but using a size_t to store values no bigger than sizeof(struct sw_flow_key) seems excessive.
This reduces sw_flow_key_range and sw_flow_mask by 4 bytes on 32-bit systems. On 64-bit systems it shrinks sw_flow_key_range by 12 bytes but sw_flow_mask only by 8 bytes due to padding.
Compile tested only.
Signed-off-by: Ben Pfaff <b...@nicira.com> Acked-by: Andy Zhou <az...@nicira.com> Signed-off-by: Jesse Gross <je...@nicira.com> --- net/openvswitch/flow.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/flow.h b/net/openvswitch/flow.h index 1510f51..176406d 100644 --- a/net/openvswitch/flow.h +++ b/net/openvswitch/flow.h @@ -122,8 +122,8 @@ struct sw_flow_key { } __aligned(BITS_PER_LONG/8); /* Ensure that we can do comparisons as longs. */ struct sw_flow_key_range { - size_t start; - size_t end; + unsigned short int start; + unsigned short int end;
*short int* seems somewhat ambiguous, no? WBR, Sergei _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev