On Mon, Dec 16, 2013 at 05:57:51PM +0900, Simon Horman wrote:
> Update the netdev_class so that struct ofpbuf * is passed to rx_recv()
> to provide both the data and size of the data to read a packet into.
> 
> On success, update struct ofpbuf size inside netdev_class rx_recv
> implementation and return 0. This moves logic from the caller.
> On error a negative error code is returned, this behaviour is unchanged
> by this patch.
> 
> This patch should not have any behavioural changes.
> 
> This patch is in preparation for the netdev-linux variant of rx_recv()
> making use of headroom in the struct ofpbuf * parameter to push a VLAN tag
> obtained from auxdata.
> 
> Signed-off-by: Simon Horman <ho...@verge.net.au>

Can you update the ->rx_recv() return value convention to be the more
conventional "0 for success otherwise positive errno value"?  We no
longer need the positive values to report lengths.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to