On Tue, Dec 17, 2013 at 1:48 PM, Pravin B Shelar <pshe...@nicira.com> wrote:
> diff --git a/datapath/flow.c b/datapath/flow.c
> index 9b3d3a7..3a50589 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> @@ -110,7 +110,9 @@ void ovs_flow_stats_get(struct sw_flow *flow, struct
> ovs_flow_stats *ovs_stats,
> memset(ovs_stats, 0, sizeof(*ovs_stats));
>
> if (!flow->stats.is_percpu) {
> + local_bh_disable();
> stats_read(flow->stats.stat, ovs_stats, used, tcp_flags);
> + local_bh_enable();
> } else {
> cur_cpu = get_cpu();
> for_each_possible_cpu(cpu) {
I think it might be more obviously correct if we push
local_bh_disable() into the read/clear function so that it is near the
spin lock and then we can pass a bool into that function.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
