Package: openvswitch
Version: 1.9.3+git20131029-1.1
Severity: important
Dear Maintainer,
I was upgrading our test server to the newest kernel shipping with
Debian/unstable,
namely "3.11-2", and DKMS failed on openvswitch-datapath-dkms. I attached the
error
messages from the DKMS make.log file.
Looking at the source file and the referenced header file, it seems that the
Linux
kernel now supports VLAN EtherTypes other than 0x8100. This has resulted in
calls
that add VLAN tags having one extra parameter, the desired EtherType.
This sounds like it would require a bigger overhaul in the openvswitch design,
but
for now I would suggest adding a simple patch that adds ETH_P_8021Q as the
extra parameter when compiling for 3.11. Note that the new parameter was added
in
the middle of the function's parameter list, not at the end.
Log follows:
CC [M]
/var/lib/dkms/openvswitch/1.9.3+git20131029/build/datapath/linux/actions.o
/var/lib/dkms/openvswitch/1.9.3+git20131029/build/datapath/linux/actions.c: In
function ‘pop_vlan’:
/var/lib/dkms/openvswitch/1.9.3+git20131029/build/datapath/linux/actions.c:104:2:
error: too few arguments to function ‘__vlan_hwaccel_put_tag’
__vlan_hwaccel_put_tag(skb, ntohs(tci));
^
In file included from
/var/lib/dkms/openvswitch/1.9.3+git20131029/build/datapath/linux/compat/include/linux/if_vlan.h:6:0,
from
/var/lib/dkms/openvswitch/1.9.3+git20131029/build/datapath/linux/actions.c:29:
/usr/src/linux-headers-3.11-2-common/include/linux/if_vlan.h:236:31: note:
declared here
static inline struct sk_buff *__vlan_hwaccel_put_tag(struct sk_buff *skb,
^
/var/lib/dkms/openvswitch/1.9.3+git20131029/build/datapath/linux/actions.c: In
function ‘push_vlan’:
/var/lib/dkms/openvswitch/1.9.3+git20131029/build/datapath/linux/actions.c:124:2:
error: too few arguments to function ‘__vlan_hwaccel_put_tag’
__vlan_hwaccel_put_tag(skb, ntohs(vlan->vlan_tci) & ~VLAN_TAG_PRESENT);
^
In file included from
/var/lib/dkms/openvswitch/1.9.3+git20131029/build/datapath/linux/compat/include/linux/if_vlan.h:6:0,
from
/var/lib/dkms/openvswitch/1.9.3+git20131029/build/datapath/linux/actions.c:29:
/usr/src/linux-headers-3.11-2-common/include/linux/if_vlan.h:236:31: note:
declared here
static inline struct sk_buff *__vlan_hwaccel_put_tag(struct sk_buff *skb,
^
make[4]: ***
[/var/lib/dkms/openvswitch/1.9.3+git20131029/build/datapath/linux/actions.o]
Error 1
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
