Thanks for the update,
On Fri, Dec 13, 2013 at 2:52 PM, Ben Pfaff <b...@nicira.com> wrote: > On Mon, Nov 25, 2013 at 12:49:45PM -0800, Alex Wang wrote: > > LGTM, only one thing, > > > > I did the following test: > > > > """ > > root@server329:~/ben-reviews# ovs-vsctl --version > > ovs-vsctl (Open vSwitch) 2.0.90 > > Compiled Nov 25 2013 11:44:29 > > root@server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l > > > > 31 > > *root@server329:~/ben-reviews# ovs-vsctl add-br test* > > root@server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l > > 44 > > *root@server329:~/ben-reviews# ip link add name foo type veth peer name > bar* > > root@server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l > > > > 44 > > *root@server329:~/ben-reviews# ovs-vsctl add-port test foo* > > root@server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l > > 45 > > *root@server329:~/ben-reviews# ip link delete foo* > > root@server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l > > 43 > > *root@server329:~/ben-reviews# **ovs-vsctl del-port foo* > > root@server329:~/ben-reviews# lsof -p `pidof ovs-vswitchd` | wc -l > > 43 > > root@server329:~/ben-reviews# > > """ > > > > > > After adding the veth, the fd count is incremented by 1. But after > > deleting it, the fd count is decremented by 2. So, seem to me that there > > is other place that can delete the vport but not the channel. > > I ran an "strace" with your sample commands. I can see netlink > sockets being opened and closed when I expect, so I think that the > behavior is OK. I see some other activity with fds, and maybe some of > that yields the surprising results. > > I think these patches are OK, so I'm going to push them soon. > > Thanks, > > Ben. >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
