I've reviewed this entire series except for the new version of the first patch. Ben, I'll be traveling all day tomorrow, so once Joe sends the new version of this patch, would you please merge the series for me?
Thanks, Ethan On Wed, Dec 11, 2013 at 10:58 AM, Joe Stringer <joestrin...@nicira.com> wrote: > On 11 December 2013 10:44, Ethan Jackson <et...@nicira.com> wrote: >> Couple of comments. >> >> Do we need a whole new module for the connectivity seq stuff? >> Couldn't we just do with an extern global struct seq *? That said, >> it's not exactly clear where we'd put it, so perhaps a separate module >> is the way to go. I don't feel strongly about it. >> >> Along those same lines, if we need a whole separate module, could all >> this be implemented with a single function: >> >> struct seq *connectivity_seq_get(). >> >> This function would create the seq if it doesn't exist, and return it. >> With this approach we don't have to deal with all the pass through >> boilerplate logic. > > This seems sensible. I had it in mind that if we wish to split up this > single seq for each protocol later, we may wish to collect them in a > separate module like this. However I don't think that's a strong > reason to leave it where it is. One alternative is to place it in > seq.[ch]. What do you think? > >> Could you move the comments for the connectivity seq stuff from the >> header file into the C file? It's not entirely clear to me why that's >> our convention, but the rest of the code does it that way, so may as >> well here to. > > Sure, I'll do that. > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
